Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev oracle #1142

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Dev oracle #1142

merged 19 commits into from
Jan 26, 2024

Conversation

ddwolf715
Copy link
Contributor

任务类型增加对Oracle库的支持。#1062

@ddwolf715
Copy link
Contributor Author

这个分支请求实现的功能,是否有没合规的地方?

@mortalYoung mortalYoung added the feature New feature label Nov 28, 2023
@ddwolf715 ddwolf715 marked this pull request as draft November 29, 2023 07:11
@ddwolf715 ddwolf715 marked this pull request as ready for review November 29, 2023 07:13
@ddwolf715
Copy link
Contributor Author

是不符合合并的要求吗?或者有什么需要修改的地方?还是直接取消这个合并请求了?

持续等待中。。。。。。。

@vainhope
Copy link
Collaborator

是不符合合并的要求吗?或者有什么需要修改的地方?还是直接取消这个合并请求了?

持续等待中。。。。。。。

枚举类型调整一下就好了

@ddwolf715
Copy link
Contributor Author

是不符合合并的要求吗?或者有什么需要修改的地方?还是直接取消这个合并请求了?
持续等待中。。。。。。。

枚举类型调整一下就好了

好的,需要如何调整?还请提示一下。

@vainhope
Copy link
Collaborator

vainhope commented Jan 5, 2024

是不符合合并的要求吗?或者有什么需要修改的地方?还是直接取消这个合并请求了?
持续等待中。。。。。。。

枚举类型调整一下就好了

好的,需要如何调整?还请提示一下。

50调整为27即可

@ddwolf715
Copy link
Contributor Author

已将枚举值从50调整为27

@@ -117,6 +117,8 @@ public enum EScheduleJobType {
MAXCOMPUTE(24, "MaxCompute", EJobType.SQL.getType(), 4, null, EComputeType.BATCH, EJobClientType.DATASOURCE_PLUGIN),
HADOOP_MR(25, "HadoopMR", EJobType.MR.getType(), 16, EComponentType.HDFS, EComputeType.BATCH, EJobClientType.WORKER_PLUGIN),
DATAX(26,"DataX", EJobType.PYTHON.getType(),14, EComponentType.DATAX, EComputeType.BATCH, EJobClientType.WORKER_PLUGIN),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oracle 枚举值辛苦调整为27 按照顺序来 目前没有其他的任务类型开发 暂时未冲突

@vainhope vainhope merged commit 5d54c0e into DTStack:master Jan 26, 2024
3 checks passed
@ddwolf715 ddwolf715 deleted the dev-oracle branch April 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants